Skip to content

fixing Waltz of the Types first example #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixing Waltz of the Types first example #606

wants to merge 1 commit into from

Conversation

@dotnetCarpenter
Copy link
Contributor

@dotnetCarpenter dotnetCarpenter commented Feb 23, 2021

By using the improved traverse function from #581 (comment)
and adding toString since the nodejs fs.readFile returns a Buffer and not a String.

// readFile :: FileName -> Task Error String

// firstWords :: String -> String
const firstWords = compose(intercalate(' '), take(3), split(' '), toString);

// tldr :: FileName -> Task Error String
const tldr = compose(map(firstWords), readFile);

traverse(Task.of, tldr, ['file1', 'file2']);
// Task(['hail the monarchy', 'smash the patriarchy']);

Before the traverse function threw a TypeError: f.traverse is not a function, on traverse(Task.of, tldr, ['file1', 'file2']);.

Thanks to @antonklimov.

@dotnetCarpenter
fixing Waltz of the Types first example
5cb5788 
By using the improved `traverse` function from MostlyAdequate#581 (comment)
and adding `toString` since the nodejs `fs.readFile` returns a Buffer and not a String.
@dotnetCarpenter dotnetCarpenter mentioned this pull request Feb 24, 2021
Open
@dotnetCarpenter
Copy link
Contributor Author

dotnetCarpenter commented Feb 24, 2021

Blocks #607

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dotnetCarpenter